Add apiextensions.CustomResource to Go SDK #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/go-custom-resource
branch
2 times, most recently
from
3cb235d to
845d8b2
Compare
lukehoban
reviewed
May 15, 2020
provider/pkg/gen/go-templates/apiextensions/customResource.tmpl
Outdated
Show resolved
Hide resolved
provider/pkg/gen/go-templates/apiextensions/customResource.tmpl
Outdated
Show resolved
Hide resolved
lblackstone
force-pushed
the
lblackstone/go-custom-resource
branch
from
ecdd82d to
fb2061b
Compare
lukehoban
approved these changes
May 15, 2020
There was a problem hiding this comment.
LGTM.
Have we manually tried a non-trivial Helm chart (or group of Config) to validate that it works well in the full E2E? (I imagine we could also add some test coverage for that - but don't necessarily need to block on the test coverage piece as we have coverage of all the individual components).
I just tried a bunch of Helm charts, and they all worked fine. I think the existing test coverage is exercising all of the basics now (YAML file, YAML folder, Helm Chart, CRDs + CRs). |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change makes it possible to create k8s
CustomResourceobjects from a YAML manifest. Still TODO:Related issues (optional)
Fixes #1116