Don't replace Service on .spec.type change #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we replaced Service resources if the .spec.type field changed. It appears that k8s can update this field in place, so switch to an update.
metral
approved these changes
May 20, 2020
lblackstone
force-pushed
the
lblackstone/service-type-update
branch
from
6488ae0 to
df8feb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, we replaced Service resources if the
.spec.type field changed. It appears that k8s can
update this field in place, so switch to an update.
Note: I tested this manually by creating a Service and then using
kubectl editto change the Service between types (LoadBalancer,ClusterIP,NodePort). In each case, k8s was able to update the Service.Related issues (optional)
Fixes #1133