Fix regression in TypeScript YAML SDK #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added back support for v1/List in YAML SDK. This was inadvertantly removed when converting over to schema-based code generation.
pgavlin
approved these changes
Jun 11, 2020
| @@ -399,8 +399,9 @@ export class ConfigFile extends CollectionComponentResource { | |||
| // for resource definitions that can be managed by Kubernetes, and registers those with the | |||
| // engine instead. | |||
| if ( | |||
| {{range $idx, $v := .ListKinds -}} {{if $idx}} | |||
| || {{else}} {{end}}(gvk === "{{$v.GVK}}") | |||
| (gvk === "v1/List") | |||
There was a problem hiding this comment.
Has this always been hand-coded, or was it auto-generated prior to the switch to schema codegen?
There was a problem hiding this comment.
v1/List was hardcoded before.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added back support for v1/List in YAML SDK. This
was inadvertantly removed when converting over to
schema-based code generation.
Related issues (optional)
Fix #1156