-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema-based python codegen #1160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
force-pushed
the
komalali/python-codegen
branch
from
June 11, 2020 21:38
9508d84
to
7a04aca
Compare
komalali
force-pushed
the
komalali/python-codegen
branch
from
June 18, 2020 19:28
702004e
to
458288b
Compare
komalali
force-pushed
the
komalali/python-codegen
branch
from
June 23, 2020 19:48
a983c34
to
1f770eb
Compare
komalali
force-pushed
the
komalali/python-codegen
branch
from
June 24, 2020 21:36
82ad45a
to
ea7438e
Compare
lblackstone
reviewed
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions. LGTM overall! 🎉
sdk/python/pulumi_kubernetes/admissionregistration/v1/MutatingWebhookConfiguration.py
Outdated
Show resolved
Hide resolved
sdk/python/pulumi_kubernetes/admissionregistration/v1/MutatingWebhookConfiguration.py
Show resolved
Hide resolved
lblackstone
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pgavlin
approved these changes
Jun 26, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues (optional)
Resolves: #1085
Resolves: #898
Resolves: #1155