-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show deprecation messages when new versions exist #1182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall!
We may eventually want to turn this into something that runs as part of code generation (translated to Go). Can you open an issue to track that? |
…er version before showing deprecation message.
b207ff4
to
a58ac0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more fix, and then LGTM
Proposed changes
We now check if the suggested kind exists in the current k8s cluster version before showing a deprecation message.
It's kind of a pain to figure out which kinds were added in which spec version, so I wrote a little node script to generate a list for me. Not sure if it's useful to put it somewhere, but I've pasted it here and open to ideas.
Related issues (optional)
Fixes: #1168