Set plugin version for Go SDK invoke calls #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For invoke calls, the version must be set to avoid using an older version of the plugin that does not support the specified invoke function. We don't currently have a way of automatically determining the version [1] to set for the Go SDK, so we're hardcoding the version to the v2.6.1 plugin for now. This version contains the latest implementation for all of our provider invoke functions. Note that all of our other SDKs are already setting the auto-discovered version in similar invoke calls. [1] #1324
EvanBoyle
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
For invoke calls, the version must be set to avoid using
an older version of the plugin that does not support the
specified invoke function. We don't currently have a way
of automatically determining the version [1] to set for the
Go SDK, so we're hardcoding the version to the v2.6.1
plugin for now. This version contains the latest
implementation for all of our provider invoke functions.
Note that all of our other SDKs are already setting the
auto-discovered version in similar invoke calls.
[1] #1324
Related issues (optional)
#1324