Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s deps #1360

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Bump k8s deps #1360

merged 3 commits into from
Nov 10, 2020

Conversation

lblackstone
Copy link
Member

Proposed changes

  • Bump helm to v3.4.0
  • Bump k8s deps to v1.19.2
  • Update dependent code as required

Related issues (optional)

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/329553433

@lblackstone lblackstone force-pushed the lblackstone/k8s-119-deps branch from 375d263 to 1cc6652 Compare October 26, 2020 18:45
@lblackstone lblackstone requested a review from metral October 26, 2020 18:45
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/329739316

@lblackstone
Copy link
Member Author

Looks like this upgrade is causing a new panic. I'll need to investigate further.

[ ts/sdk/nodejs/examples/mariadb ]   pulumi:pulumi:Stack (mariadb-p-it-fv-az54-mariadb-c37611a1):
[ ts/sdk/nodejs/examples/mariadb ]     panic: cannot deep copy resource.Computed
[ ts/sdk/nodejs/examples/mariadb ]     goroutine 39 [running]:
[ ts/sdk/nodejs/examples/mariadb ]     k8s.io/apimachinery/pkg/runtime.DeepCopyJSONValue(0x277fee0, 0xc0008c2d30, 0xc0005fb2e0, 0xc00166a0c0)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/runtime/converter.go:466 +0x4e6
[ ts/sdk/nodejs/examples/mariadb ]     k8s.io/apimachinery/pkg/runtime.DeepCopyJSONValue(0x27145c0, 0xc001643c50, 0xc00163c2b6, 0xa)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/runtime/converter.go:450 +0x157
[ ts/sdk/nodejs/examples/mariadb ]     k8s.io/apimachinery/pkg/runtime.DeepCopyJSONValue(0x27145c0, 0xc001643c20, 0x0, 0x0)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/runtime/converter.go:450 +0x157
[ ts/sdk/nodejs/examples/mariadb ]     k8s.io/apimachinery/pkg/runtime.DeepCopyJSON(...)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/runtime/converter.go:435
[ ts/sdk/nodejs/examples/mariadb ]     k8s.io/apimachinery/pkg/apis/meta/v1/unstructured.(*Unstructured).DeepCopy(0xc001699778, 0xc001611d40)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/apis/meta/v1/unstructured/unstructured.go:146 +0x75
[ ts/sdk/nodejs/examples/mariadb ]     github.com/pulumi/pulumi-kubernetes/provider/v2/pkg/provider.withLastAppliedConfig(0xc001699778, 0xc001699778, 0x2aaeb28, 0xc001643c20)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/work/pulumi-kubernetes/pulumi-kubernetes/provider/pkg/provider/provider.go:2278 +0x65
[ ts/sdk/nodejs/examples/mariadb ]     github.com/pulumi/pulumi-kubernetes/provider/v2/pkg/provider.(*kubeProvider).Create(0xc0008cf2c0, 0x2cd5020, 0xc001643a40, 0xc001646d70, 0xc0008cf2c0, 0x2729c01, 0xc001645080)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/work/pulumi-kubernetes/pulumi-kubernetes/provider/pkg/provider/provider.go:1421 +0x3db
[ ts/sdk/nodejs/examples/mariadb ]     github.com/pulumi/pulumi/sdk/v2/proto/go._ResourceProvider_Create_Handler.func1(0x2cd5020, 0xc001643a40, 0x28be160, 0xc001646d70, 0x28ddd20, 0x3e0a8c8, 0x2cd5020, 0xc001643a40)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v2@v2.11.3-0.20201012185126-156aa9862e15/proto/go/provider.pb.go:2244 +0x89
[ ts/sdk/nodejs/examples/mariadb ]     github.com/grpc-ecosystem/grpc-opentracing/go/otgrpc.OpenTracingServerInterceptor.func1(0x2cd5020, 0xc001643890, 0x28be160, 0xc001646d70, 0xc00163f2a0, 0xc00163f2c0, 0x0, 0x0, 0x2c7ad20, 0xc000608150)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/github.com/grpc-ecosystem/grpc-opentracing@v0.0.0-20180507213350-8e809c8a8645/go/otgrpc/server.go:57 +0x2f6
[ ts/sdk/nodejs/examples/mariadb ]     github.com/pulumi/pulumi/sdk/v2/proto/go._ResourceProvider_Create_Handler(0x2951620, 0xc0008cf2c0, 0x2cd5020, 0xc001643890, 0xc001650d20, 0xc00052e880, 0x2cd5020, 0xc001643890, 0xc0016eae00, 0x1be)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v2@v2.11.3-0.20201012185126-156aa9862e15/proto/go/provider.pb.go:2246 +0x150
[ ts/sdk/nodejs/examples/mariadb ]     google.golang.org/grpc.(*Server).processUnaryRPC(0xc0000beea0, 0x2cef9c0, 0xc000001b00, 0xc001648600, 0xc000563ad0, 0x3b85848, 0x0, 0x0, 0x0)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:1082 +0x522
[ ts/sdk/nodejs/examples/mariadb ]     google.golang.org/grpc.(*Server).handleStream(0xc0000beea0, 0x2cef9c0, 0xc000001b00, 0xc001648600, 0x0)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:1405 +0xcc5
[ ts/sdk/nodejs/examples/mariadb ]     google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc00054cb30, 0xc0000beea0, 0x2cef9c0, 0xc000001b00, 0xc001648600)
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:746 +0xa5
[ ts/sdk/nodejs/examples/mariadb ]     created by google.golang.org/grpc.(*Server).serveStreams.func1
[ ts/sdk/nodejs/examples/mariadb ]     	/home/runner/go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:744 +0xa5
[ ts/sdk/nodejs/examples/mariadb ]  
[ ts/sdk/nodejs/examples/mariadb ]   kubernetes:core/v1:Secret (mariadb-app):
[ ts/sdk/nodejs/examples/mariadb ]     error: Preview failed: transport is closing
[ ts/sdk/nodejs/examples/mariadb ]  
[ ts/sdk/nodejs/examples/mariadb ]   kubernetes:core/v1:Service (mariadb-app):
[ ts/sdk/nodejs/examples/mariadb ]     error: transport is closing

@lblackstone
Bump k8s deps
5555d20 
- Bump helm to v3.4.0
- Bump k8s deps to v1.19.2
- Update dependent code as required
@lblackstone lblackstone force-pushed the lblackstone/k8s-119-deps branch from 1cc6652 to 5555d20 Compare November 10, 2020 21:57
@lblackstone lblackstone removed the request for review from metral November 10, 2020 21:58
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/356683129

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/356715304

@lblackstone lblackstone marked this pull request as ready for review November 10, 2020 22:41
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

justinvp
justinvp approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lblackstone lblackstone merged commit bb050fd into master Nov 10, 2020
@pulumi-bot pulumi-bot deleted the lblackstone/k8s-119-deps branch November 10, 2020 23:04
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

@komalali komalali Awaiting requested review from komalali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lblackstone @justinvp