Error on delete if cluster is unreachable #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously considered a resource to be deleted if the cluster is unreachable during an update. The intent was to gracefully handle cases where the underlying cluster was deleted (perhaps as part of another stack). Unfortunately, this change led to cases where resources were erroneously deleted from the state due to network partitions. This change reverts that behavior so that an error is returned for resource deletion if the cluster is unreachable.
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
/run-acceptance-tests |
|
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/360301945 |
justinvp
approved these changes
Nov 12, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We previously considered a resource to be deleted if the
cluster is unreachable during an update. The intent was to
gracefully handle cases where the underlying cluster was
deleted (perhaps as part of another stack). Unfortunately,
this change led to cases where resources were erroneously
deleted from the state due to network partitions.
This change reverts that behavior so that an error is returned
for resource deletion if the cluster is unreachable.
Related issues (optional)
Fix #1013