-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip Helm test hook resources by default #1467
Conversation
Many Helm charts include test hooks that can be used by the "helm test" command to validate an installation, but should not be included as part of a default chart installation. This change disables the creation of test resources by default, and includes a new Chart parameter that can be used to override this default and install the test resources.
@jaxxstorm I wanted to make sure that this change makes sense to you as a user. We previously started implementing this change in #666 Here's a before and after example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The PR description mentioned something about a parameter to disable skipping of the installation but didn't see it in the PR? Did you want to add that separately?
Update - Ah its a draft. Nevermind :)
Proposed changes
Many Helm charts include test hooks that can be
used by the "helm test" command to validate an
installation, but should not be included as part of
a default chart installation. This change disables
the creation of test resources by default, and includes
a new Chart parameter that can be used to override
this default and install the test resources.
Related issues (optional)
Related to #665