Change k8s API removals from error to warning #1475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The provider checks for deprecated and removed API
versions of k8s resources to provide clearer messages
for affected APIs. These messages are intended to be
informational, and should not block the deployment of
a resource if the cluster accepts it. To avoid inadvertently
failing a deployment when the upstream removal version
has changed, print a warning rather than returning an error.
Here's what this looks like now for a removed API:
Preview
(This previously would have returned an error)
Update
(An error is returned, but it's only after the cluster reported that the resource was not available.)
Related issues (optional)
Related to #1388