Do not return IDs when previewing creates. #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, return the empty string. This will prevent the engine and core SDKs from treating an uncreated resource's ID as known. Fixes pulumi/pulumi#5728.
|
Though I'm fairly confident that we should take this, I do want to point out that it is a behavioral change and may reduce the efficacy of previews if resources are connected via IDs. That said, it will correct problems like those mentioned in the linked issue, and better reflects the intended semantics of known vs. unknown IDs. |
lblackstone
requested changes
Apr 14, 2021
| @@ -0,0 +1,52 @@ | |||
| # Copyright 2016-2020, Pulumi Corporation. | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2016-2020, Pulumi Corporation. | |
| # Copyright 2016-2021, Pulumi Corporation. |
|
|
||
| import pulumi | ||
| from pulumi_kubernetes.apiextensions.CustomResource import CustomResource | ||
| from pulumi_kubernetes.apiextensions.v1beta1.CustomResourceDefinition import ( |
There was a problem hiding this comment.
apiextensions/v1beta1 is deprecated and will be removed in the next k8s release. It would be better to use apiextensions/v1 for these.
lblackstone
approved these changes
Apr 14, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, return the empty string. This will prevent the engine and core
SDKs from treating an uncreated resource's ID as known.
Fixes pulumi/pulumi#5728.