Add replaceOnUpdate annotation to force resource replacement #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `pulumi.com/replaceOnUpdate` to "true" will cause the resource to be replaced on subsequent updates.
Does the PR have any schema changes?Looking good! No breaking changes found. |
lukehoban
reviewed
May 4, 2021
| // If the replaceOnUpdate annotation is "true", then schedule the resource for replacement. | ||
| if metadata.ReplaceOnUpdate(newInputs) { | ||
| hasChanges = pulumirpc.DiffResponse_DIFF_SOME | ||
| replaces = append(replaces, `.metadata.annotations["pulumi.com/replaceOnUpdate"]`) |
There was a problem hiding this comment.
Will this force a diff and replacement always, even if there are no changes? I thought the goal was to replace only if there were changes?
There was a problem hiding this comment.
Will this force a diff and replacement always, even if there are no changes?
Correct. I thought this would be required for the Job replacement case, but narrowing it to only apply on changes does seem preferable. I'll do some more testing today.
|
I'm closing this in favor of the more general solution in pulumi/pulumi#7226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Setting
pulumi.com/replaceOnUpdateto "true" will cause the resourceto be replaced on subsequent updates.
Reviewer note:
I still need to add tests, but wanted to make sure the overall approach makes sense.
Here's an example of what this looks like in the CLI with the annotation set.
Related issues (optional)
Fix #1007