-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CRD rendering conditional for Helm v3 #1572
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
@@ -26,7 +26,7 @@ import ( | |||
var baseOptions = &integration.ProgramTestOptions{ | |||
Verbose: true, | |||
Dependencies: []string{ | |||
"github.com/pulumi/pulumi-kubernetes/sdk/v3/go", | |||
"github.com/pulumi/pulumi-kubernetes/sdk/v3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is right. Pretty sure I had to change this recently to get tests passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was running into issues getting the test to run locally without this since the test framework installs a replace block mapping to pulumi/pulumi-kubernetes/sdk/go
which doesn't have a go.mod. It did work locally with the above change but the CI run is failing. Will investigate.
866c4a6
to
9c83832
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
abe7b40
to
d75eb54
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
033a1c5
to
5eef3b2
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
Fixes #1195