Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skipAwait option to Helm v3.Chart #1603

Merged
merged 6 commits into from
Jun 14, 2021
Merged

Add skipAwait option to Helm v3.Chart #1603

merged 6 commits into from
Jun 14, 2021

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Jun 8, 2021 •
edited
Loading

Proposed changes

Related issues (optional)

Partial fix for #1421

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone force-pushed the lblackstone/helm-skip-await branch from 3535ab7 to f92d2ff Compare June 8, 2021 21:39
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone force-pushed the lblackstone/helm-skip-await branch from f92d2ff to fea5211 Compare June 8, 2021 23:42
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone
Copy link
Member Author

@viveklak @mikhailshilkov I'm still working through .NET and Go, but open to early feedback here

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@viveklak
Copy link
Contributor

viveklak commented Jun 9, 2021

LGTM so far.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone marked this pull request as ready for review June 10, 2021 17:27
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

mikhailshilkov
mikhailshilkov approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some formatting nits

provider/pkg/gen/dotnet-templates/helm/v3/Chart.cs Outdated Show resolved Hide resolved
provider/pkg/gen/dotnet-templates/helm/v3/Chart.cs Show resolved Hide resolved
provider/pkg/gen/dotnet-templates/helm/v3/Chart.cs Outdated Show resolved Hide resolved
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone force-pushed the lblackstone/helm-skip-await branch from ef58c91 to fd17099 Compare June 14, 2021 16:53
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone force-pushed the lblackstone/helm-skip-await branch from fd17099 to bf831eb Compare June 14, 2021 16:54
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone merged commit 1070320 into master Jun 14, 2021
@pulumi-bot pulumi-bot deleted the lblackstone/helm-skip-await branch June 14, 2021 17:33
@renovate renovate bot mentioned this pull request Jun 17, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhailshilkov mikhailshilkov mikhailshilkov approved these changes

@viveklak viveklak Awaiting requested review from viveklak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lblackstone @viveklak @mikhailshilkov