Handle different namespaces for server-side diff #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server-side diff logic previously tried to use the same k8s client for calculating the patch. In the case where the namespace of a resource changed, this diff would fail because the client was for the old namespace.
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
| client, err := k.clientSet.ResourceClient(newInputs.GroupVersionKind(), newInputs.GetNamespace()) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| newObject, err = client.Create(context.TODO(), newInputs, metav1.CreateOptions{ |
There was a problem hiding this comment.
I'm just trying to wrap my head around this... What happens with the object in the old namespace? Don't we need to delete it?
There was a problem hiding this comment.
This method just computes the patch. The resource replacement logic happens separately from this.
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
approved these changes
Jun 23, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The server-side diff logic previously tried to use the
same k8s client for calculating the patch. In the case
where the namespace of a resource changed, this
diff would fail because the client was for the old
namespace.
Related issues (optional)
Fix #683