Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk/python] yaml. _parse_yaml_object wait only for metadata name and namespace instead of all metadata #1675

Merged
merged 2 commits into from
Aug 12, 2021
Merged

[sdk/python] yaml. _parse_yaml_object wait only for metadata name and namespace instead of all metadata #1675

merged 2 commits into from
Aug 12, 2021

Conversation

SharpEdgeMarshall
Copy link
Contributor

Proposed changes

Use Output.all only on metadata.name and namespace instead of all metadata in yaml._parse_yaml_object

Related issues (optional)

Fix #1674

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@mikhailshilkov
Copy link
Member

Thank you for the PR! This makes sense to me and is in line with the node implementation here

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/1120574577

lblackstone
lblackstone reviewed Aug 11, 2021
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM once it's added to the codegen template

sdk/python/pulumi_kubernetes/yaml.py Show resolved Hide resolved
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@SharpEdgeMarshall SharpEdgeMarshall changed the title Fix #1674 [sdk/python] yaml. _parse_yaml_object wait only for metadata name and namespace instead of all metadata Aug 12, 2021
@lblackstone
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/1124477586

lblackstone
lblackstone approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@lblackstone lblackstone merged commit f085802 into pulumi:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sdk/python] yaml._parse_yaml_object waits for all metadata
3 participants
@SharpEdgeMarshall @mikhailshilkov @lblackstone