Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Kubernetes v1.23.0 #1681

Merged
merged 4 commits into from
Dec 7, 2021
Merged

Add support for Kubernetes v1.23.0 #1681

merged 4 commits into from
Dec 7, 2021

Conversation

lblackstone
Copy link
Member

Related issues (optional)

Fix #1680

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchema
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchemaList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfiguration
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfigurationList

1 similar comment
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchema
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchemaList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfiguration
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfigurationList

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Does the PR have any schema changes?

Found 2 breaking changes:
Type "kubernetes:core/v1:Lifecycle" input "postStart" type changed from "#/types/kubernetes:core/v1:Handler" to "#/types/kubernetes:core/v1:LifecycleHandler"
Type "kubernetes:core/v1:Lifecycle" input "preStop" type changed from "#/types/kubernetes:core/v1:Handler" to "#/types/kubernetes:core/v1:LifecycleHandler"

New resources:

  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchema
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchemaList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfiguration
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfigurationList

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

Does the PR have any schema changes?

Found 2 breaking changes:
Type "kubernetes:core/v1:Lifecycle" input "preStop" type changed from "#/types/kubernetes:core/v1:Handler" to "#/types/kubernetes:core/v1:LifecycleHandler"
Type "kubernetes:core/v1:Lifecycle" input "postStart" type changed from "#/types/kubernetes:core/v1:Handler" to "#/types/kubernetes:core/v1:LifecycleHandler"

New resources:

  • kubernetes:autoscaling/v2:HorizontalPodAutoscaler
  • kubernetes:autoscaling/v2:HorizontalPodAutoscalerList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchema
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchemaList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfiguration
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfigurationList

@lblackstone lblackstone marked this pull request as ready for review December 3, 2021 20:57
@lblackstone lblackstone requested a review from viveklak December 3, 2021 20:58
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Does the PR have any schema changes?

Found 2 breaking changes:
Type "kubernetes:core/v1:Lifecycle" input "postStart" type changed from "#/types/kubernetes:core/v1:Handler" to "#/types/kubernetes:core/v1:LifecycleHandler"
Type "kubernetes:core/v1:Lifecycle" input "preStop" type changed from "#/types/kubernetes:core/v1:Handler" to "#/types/kubernetes:core/v1:LifecycleHandler"

New resources:

  • kubernetes:autoscaling/v2:HorizontalPodAutoscaler
  • kubernetes:autoscaling/v2:HorizontalPodAutoscalerList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchema
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchemaList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfiguration
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfigurationList

viveklak
viveklak reviewed Dec 4, 2021
View reviewed changes
sdk/nodejs/rbac/v1alpha1/clusterRoleBinding.ts
@@ -6,7 +6,7 @@ import { input as inputs, output as outputs, enums } from "../../types";
import * as utilities from "../../utilities";

/**
* ClusterRoleBinding references a ClusterRole, but not contain it. It can reference a ClusterRole in the global namespace, and adds who information via Subject. Deprecated in v1.17 in favor of rbac.authorization.k8s.io/v1 ClusterRoleBinding, and will no longer be served in v1.22.
* ClusterRoleBinding references a ClusterRole, but not contain it. It can reference a ClusterRole in the global namespace, and adds who information via Subject. Deprecated in v1.17 in favor of rbac.authorization.k8s.io/v1 ClusterRoleBinding, and will no longer be served in v1.20.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with these updates to deprecations from the past?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's odd. I'm guessing they actually removed in v1.20 but forgot to update the comment, but I'll have to check.

viveklak
viveklak approved these changes Dec 4, 2021
View reviewed changes
Copy link
Contributor

@viveklak viveklak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine in general. Just the one question.

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Does the PR have any schema changes?

Found 2 breaking changes:
Type "kubernetes:core/v1:Lifecycle" input "postStart" type changed from "#/types/kubernetes:core/v1:Handler" to "#/types/kubernetes:core/v1:LifecycleHandler"
Type "kubernetes:core/v1:Lifecycle" input "preStop" type changed from "#/types/kubernetes:core/v1:Handler" to "#/types/kubernetes:core/v1:LifecycleHandler"

New resources:

  • kubernetes:autoscaling/v2:HorizontalPodAutoscaler
  • kubernetes:autoscaling/v2:HorizontalPodAutoscalerList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchema
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchemaList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfiguration
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfigurationList

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Does the PR have any schema changes?

Found 2 breaking changes:
Type "kubernetes:core/v1:Lifecycle" input "postStart" type changed from "#/types/kubernetes:core/v1:Handler" to "#/types/kubernetes:core/v1:LifecycleHandler"
Type "kubernetes:core/v1:Lifecycle" input "preStop" type changed from "#/types/kubernetes:core/v1:Handler" to "#/types/kubernetes:core/v1:LifecycleHandler"

New resources:

  • kubernetes:autoscaling/v2:HorizontalPodAutoscaler
  • kubernetes:autoscaling/v2:HorizontalPodAutoscalerList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchema
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:FlowSchemaList
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfiguration
  • kubernetes:flowcontrol.apiserver.k8s.io/v1beta2:PriorityLevelConfigurationList

@lblackstone lblackstone merged commit 3d0c3ad into master Dec 7, 2021
@pulumi-bot pulumi-bot deleted the lblackstone/k8s-1.23 branch December 7, 2021 20:52
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveklak viveklak viveklak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support k8s 1.23 on release
2 participants
@lblackstone @viveklak