[dotnet] fix parsing of CustomResources #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
requested changes
Oct 4, 2021
There was a problem hiding this comment.
Thanks for the PR, @polivbr!
@mikhailshilkov, could you review this? LGTM, but C# is not my strong suit.
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
/run-acceptance-tests |
|
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/1305326632 |
lblackstone
approved these changes
Oct 4, 2021
mikhailshilkov
approved these changes
Oct 5, 2021
|
Interesting. Will this also fix #1225? |
Possibly -- I'm pretty surprised that this wasn't caught before, because it seems like it should have prevented a lot of Helm and YAML resources from working correctly in C#. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There is a bug in the .NET SDK where it attempts to create CustomResourceDefinitions rather than CustomResources
for unknown resource types. This PR fixes this.
Related issues (optional)
#1120