Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Release: Await deletion if skipAwait is unset or atomic is specified #1742

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Helm Release: Await deletion if skipAwait is unset or atomic is specified #1742

merged 5 commits into from
Oct 6, 2021

Conversation

viveklak
Copy link
Contributor

@viveklak viveklak commented Oct 1, 2021 •
edited
Loading

Fixes #1739

Bumps Helm to v3.7.0 to pull in support for await on uninstall.

@viveklak viveklak requested a review from lblackstone October 1, 2021 03:25
@viveklak viveklak force-pushed the vl/BlockOnDeletion branch from c2ebdfe to cee8e85 Compare October 1, 2021 03:31
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

2 similar comments
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@viveklak viveklak changed the title Helm Release: Await deletion if skipAwait is unset or atomic is specific Helm Release: Await deletion if skipAwait is unset or atomic is specified Oct 1, 2021
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone
Copy link
Member

Would like to add a test for this. Possibly inject a finalizer chain? Open to suggestions.

Simplest thing I can think of would be a time check. It's pretty brute force, but if the time difference is more than a few seconds, it should be possible to assert on the time that the deletion takes.

If that's not working out, it's probably ok to validate manually for now.

@viveklak viveklak force-pushed the vl/BlockOnDeletion branch from 23f136c to 08117c6 Compare October 6, 2021 16:51
@viveklak
Copy link
Contributor Author

viveklak commented Oct 6, 2021

Sadly couldn't get a reliable test for the suite here. I think this is safe to merge as is if the existing tests pass.

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

lblackstone
lblackstone reviewed Oct 6, 2021
View reviewed changes
provider/go.sum Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@viveklak viveklak merged commit f3dea10 into master Oct 6, 2021
@pulumi-bot pulumi-bot deleted the vl/BlockOnDeletion branch October 6, 2021 19:43
@gitfool gitfool mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

@mikhailshilkov mikhailshilkov Awaiting requested review from mikhailshilkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Helm/Release] uninstall should be able to wait
2 participants
@viveklak @lblackstone