-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk/python] Add ready attribute to await Helm charts #1782
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
pulumi>=2.0.0,<3.0.0 | ||
pulumi>=3.0.0,<4.0.0 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// Copyright 2016-2020, Pulumi Corporation. | ||
// Copyright 2016-2021, Pulumi Corporation. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
|
@@ -19,6 +19,7 @@ import ( | |
"fmt" | ||
"os" | ||
"path/filepath" | ||
"regexp" | ||
"sort" | ||
"strings" | ||
"testing" | ||
|
@@ -360,6 +361,34 @@ func TestHelmLocal(t *testing.T) { | |
} | ||
options := baseOptions.With(integration.ProgramTestOptions{ | ||
Dir: filepath.Join(cwd, "helm-local", "step1"), | ||
ExtraRuntimeValidation: func(t *testing.T, stackInfo integration.RuntimeValidationStackInfo) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is neat! DId you verify this fails before the fix? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep! Without the fix, both ConfigMap resources will create before the Deployment and Service. |
||
// Verify resource creation order using the Event stream. The Chart resources must be created | ||
// first, followed by the dependent ConfigMap. (The ConfigMap doesn't actually need the Chart, but | ||
// it creates almost instantly, so it's a good choice to test creation ordering) | ||
cmRegex := regexp.MustCompile(`ConfigMap::nginx-server-block`) | ||
svcRegex := regexp.MustCompile(`Service::nginx`) | ||
deployRegex := regexp.MustCompile(`Deployment::nginx`) | ||
dependentRegex := regexp.MustCompile(`ConfigMap::foo`) | ||
|
||
var configmapFound, serviceFound, deploymentFound, dependentFound bool | ||
for _, e := range stackInfo.Events { | ||
if e.ResOutputsEvent != nil { | ||
switch { | ||
case cmRegex.MatchString(e.ResOutputsEvent.Metadata.URN): | ||
configmapFound = true | ||
case svcRegex.MatchString(e.ResOutputsEvent.Metadata.URN): | ||
serviceFound = true | ||
case deployRegex.MatchString(e.ResOutputsEvent.Metadata.URN): | ||
deploymentFound = true | ||
case dependentRegex.MatchString(e.ResOutputsEvent.Metadata.URN): | ||
dependentFound = true | ||
} | ||
assert.Falsef(t, dependentFound && !(configmapFound && serviceFound && deploymentFound), | ||
"dependent ConfigMap created before all chart resources were ready") | ||
fmt.Println(e.ResOutputsEvent.Metadata.URN) | ||
} | ||
} | ||
}, | ||
EditDirs: []integration.EditDir{ | ||
{ | ||
Dir: filepath.Join(cwd, "helm-local", "step2"), | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be >= 3.9.0 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but I figured I'd leave it as is so that it's easier to find/replace when 4.0 rolls around.