Update CustomResource python implementation to pickup snake-case updates #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
CC @justinvp for his python SDK expertise. As stated in the description, I would love to find a way to bring this inline with the rest of SDK codegen. I will cut a separate issue to consider options here since it might have an overlap with other provider SDKs as well. |
lblackstone
reviewed
Nov 2, 2021
| def __init__(__self__, *, | ||
| api_version: pulumi.Input[str], | ||
| kind: pulumi.Input[str], | ||
| compat: Optional[pulumi.Input[str]] = None, |
There was a problem hiding this comment.
What's the compat arg for? I don't see a corresponding docstring.
There was a problem hiding this comment.
Left over from attempt to codegen. Removed.
| __props__['spec'] = spec | ||
| __props__['metadata'] = metadata | ||
|
|
||
| # resource_args, opts = _utilities.get_resource_args_opts(CustomResourceArgs, pulumi.ResourceOptions, *args, **kwargs) |
lblackstone
approved these changes
Nov 2, 2021
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refresh the python implementation of python implementation of CustomResource to pick up fixes in snake-casing.
CustomResource.py is hand-crafted wrapper so doesn't lie on the codegen path. While I was able to schematize the core CustomResource type, the custom handling around constructing dynamic tokens at resource registration or retrieval is quite painful to substitute in an automated way. That would have to follow in #1778.
The change here uses an input type which signals the pulumi python SDK to handle the snake casing appropriately. I am not yet exposing the input type in the constructor with the interest of not breaking compatibility.
Related issues (optional)
Fixes #1740