Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pulumi.Input in Helm Chart API #241

Merged
merged 4 commits into from
Nov 14, 2018
Merged

Use pulumi.Input in Helm Chart API #241

merged 4 commits into from
Nov 14, 2018

Conversation

hausdorff
Copy link
Contributor

No description provided.

@hausdorff hausdorff force-pushed the hausdorff/helm-input branch 4 times, most recently from d52c0e1 to 04ebeae Compare October 16, 2018 18:01
lukehoban
lukehoban reviewed Oct 16, 2018
View reviewed changes
sdk/nodejs/yarn.lock Outdated
version "0.15.1"
resolved "https://registry.yarnpkg.com/@pulumi/pulumi/-/pulumi-0.15.1.tgz#1b94077ec0bfb8fef868d6aa66643d7f726c0678"
"@pulumi/pulumi@dev":
version "0.16.1-dev-1539638908-g00a22b27"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to release this package today - we would ideally not depend on unreleased @pulumi/pulumi builds. Can we work around the issue in that layer for now so that we can release a version of the Kubernetes package based on 0.16 of the @pulumi/pulumi package? Or is a patch release of @pulumi/pulumi strictly necessary to deliver this fix in @pulumi/kubernetes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Let's do it.

@hausdorff hausdorff force-pushed the hausdorff/helm-input branch from 04ebeae to 54c60f0 Compare October 16, 2018 19:26
@hausdorff hausdorff changed the title WIP: Use pulumi.Input in Helm Chart API Use pulumi.Input in Helm Chart API Oct 16, 2018
@hausdorff hausdorff force-pushed the hausdorff/helm-input branch 2 times, most recently from 8d741ca to 4e73958 Compare October 16, 2018 21:25
lukehoban
lukehoban approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/gen/node-templates/provider.ts.mustache Outdated Show resolved Hide resolved
@lukehoban lukehoban added the impact/breaking Fixing this issue will require a breaking change label Oct 16, 2018
@pgavlin pgavlin force-pushed the hausdorff/helm-input branch from 4e73958 to 584a062 Compare November 9, 2018 21:31
@pgavlin pgavlin force-pushed the hausdorff/helm-input branch from a5aa8ae to eb33a11 Compare November 10, 2018 01:42
@pgavlin
Copy link
Member

pgavlin commented Nov 13, 2018

@lukehoban @hausdorff this is ready for review.

hausdorff
hausdorff commented Nov 14, 2018
View reviewed changes
Copy link
Contributor Author

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I really like the direction here. Couple of questions about UX -- personally I'm ok punting the suggested work (or not doing it) as long as we're all on board with what the UX we want in the medium-term is.

pkg/gen/nodejs-templates/helm.ts.mustache Outdated Show resolved Hide resolved
pkg/gen/nodejs-templates/helm.ts.mustache Show resolved Hide resolved
@pgavlin
Copy link
Member

pgavlin commented Nov 14, 2018

Here's the preview experience: https://asciinema.org/a/rFMPmQwBjz4Vo5kApBKKvULih

hausdorff
hausdorff commented Nov 14, 2018
View reviewed changes
pkg/gen/nodejs-templates/helm.ts.mustache
});

this.resources = allConfig.apply(cfg => {
// Create temporary directories and files to hold chart data and override values.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, eek, I almost missed this -- these are tabs. Can we please double-check the formatting to make sure it's consistent with what we have? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this now--got a little itchy on the trigger.

@pgavlin pgavlin merged commit 8da9a50 into master Nov 14, 2018
@pulumi-bot pulumi-bot deleted the hausdorff/helm-input branch November 14, 2018 21:48
@pgavlin pgavlin mentioned this pull request Nov 14, 2018
Closed
lukehoban pushed a commit to pulumi/examples that referenced this pull request Dec 14, 2018
Adopt breaking change in Helm chart API
15e5f86 
Adapt to changes in v0.18.0 from pulumi/pulumi-kubernetes#241.
@lukehoban lukehoban mentioned this pull request Dec 14, 2018
Merged
lukehoban added a commit to pulumi/examples that referenced this pull request Dec 15, 2018
@lukehoban
Adopt breaking change in Helm chart API (#194)
dffb7cf 
Adapt to changes in v0.18.0 from pulumi/pulumi-kubernetes#241.
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 7, 2019
@lukehoban
Adopt breaking change in Helm chart API (pulumi#194)
8829053 
Adapt to changes in v0.18.0 from pulumi/pulumi-kubernetes#241.
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 13, 2019
@lukehoban
Adopt breaking change in Helm chart API (pulumi#194)
1aa6dc2 
Adapt to changes in v0.18.0 from pulumi/pulumi-kubernetes#241.
dixler pushed a commit to pulumi/examples that referenced this pull request Jan 21, 2022
@lukehoban
Adopt breaking change in Helm chart API (#194)
25ef951 
Adapt to changes in v0.18.0 from pulumi/pulumi-kubernetes#241.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgavlin pgavlin pgavlin left review comments

@lukehoban lukehoban lukehoban approved these changes

@CyrusNajmabadi CyrusNajmabadi Awaiting requested review from CyrusNajmabadi

Assignees
No one assigned
Labels
impact/breaking Fixing this issue will require a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hausdorff @pgavlin @lukehoban