Improved search functionality for Helm Import #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquitales
reviewed
Oct 18, 2023
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
| - helm.v3.Release: Improved cancellation support (https://github.com/pulumi/pulumi-kubernetes/pull/2579) | |||
| - Update Kubernetes client library to v0.28.2 (https://github.com/pulumi/pulumi-kubernetes/pull/2585) | |||
| - Fix for Helm Import regression (https://github.com/pulumi/pulumi-kubernetes/pull/2605) | |||
| - Improved search functionality for Helm Import (https://github.com/pulumi/pulumi-kubernetes/pull/2610) | |||
There was a problem hiding this comment.
Can you rebase this PR on top of the latest master? This line might end up in the wrong place if we don't rebase correctly.
There was a problem hiding this comment.
Yes, I will rebase carefully after #2596 is merged.
iwahbe
reviewed
Oct 18, 2023
rquitales
approved these changes
Oct 19, 2023
EronWright
force-pushed
the
eronwright/issue-2596-search
branch
from
a02c6a8 to
2260a00
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR enhances the
Releaseresource to search harder for a matching chart when importing a release. When Helm installs a chart, it doesn't record any information about the chart location, simply its name. Pulumi attempts to locate a chart:nginx/) in the program directory.nginx-15.3.4.tgz).Related issues (optional)