Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Release: populate ApiVersions and KubeVersion during templating #2653

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

EronWright
Copy link
Contributor

Proposed changes

This PR passes kubeVersion and apiVersions info from the server to Helm to fix a regression that occurred in #2568.

Related issues (optional)

Fixes: #2631

@EronWright EronWright requested a review from rquitales November 4, 2023 17:49
@EronWright EronWright added the kind/bug Some behavior is incorrect or out of spec label Nov 4, 2023
Copy link

github-actions bot commented Nov 4, 2023

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@EronWright EronWright force-pushed the eronwright/issue-2631 branch from 3cb4aba to fa62c51 Compare November 4, 2023 17:53
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #2653 (f9b205b) into master (77f09b3) will increase coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2653      +/-   ##
==========================================
+ Coverage   18.33%   18.51%   +0.18%     
==========================================
  Files          47       47              
  Lines        9632     9644      +12     
==========================================
+ Hits         1766     1786      +20     
+ Misses       7767     7754      -13     
- Partials       99      104       +5     
Files Coverage Δ
provider/pkg/provider/helm_release.go 4.11% <0.00%> (-0.02%) ⬇️
provider/pkg/provider/invoke_helm_template.go 5.18% <0.00%> (-0.18%) ⬇️

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@rquitales
Copy link
Member

@EronWright An unrelated test TestSkipUpdateUnreachableFlag is failing across CI. This should be fixed by #2657. I'm happy for the PR to be submitted as is, without rebasing on top of this change to save on CI time to get this released. We still need to ensure that post-submit CI is green before cutting a release anyway.

@johnsonp57
Copy link

@EronWright I am still getting the kubeVersion error on deployment of cert-manager - noticed that the JsonNames (lines 400/402) are transposed here:
https://github.com/pulumi/pulumi-kubernetes/blob/master/provider/pkg/gen/dotnet-templates/helm/v3/Chart.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.5.1: chart requires kubeVersion: >=1.23.0-0 which is incompatible with Kubernetes v1.20.0
3 participants