Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated codedocs for yaml/v2 #2912

Merged
merged 3 commits into from
Mar 28, 2024
Merged

updated codedocs for yaml/v2 #2912

merged 3 commits into from
Mar 28, 2024

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented Mar 27, 2024

Proposed changes

Updated the codedocs for new ConfigGroup and ConfigFile (v2) resources. A working example is also provided for YAML and Java.

Related issues (optional)

Closes #2868

@EronWright EronWright added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Mar 27, 2024
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@EronWright EronWright changed the title updated docs updated codedocs for yaml/v2 Mar 27, 2024
@EronWright EronWright requested a review from a team March 27, 2024 18:42
Copy link
Member

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'll need to rebuild schema and sdks to get CI green.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.63%. Comparing base (76baec9) to head (ea3d841).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2912   +/-   ##
=======================================
  Coverage   27.63%   27.63%           
=======================================
  Files          54       54           
  Lines        7862     7862           
=======================================
  Hits         2173     2173           
  Misses       5504     5504           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EronWright EronWright enabled auto-merge (squash) March 28, 2024 18:34
@EronWright EronWright merged commit 1010333 into master Mar 28, 2024
18 checks passed
@EronWright EronWright deleted the eronwright/issue-2868 branch March 28, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yaml impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the codedoc examples for Yaml V2 components
2 participants