-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate provider SDK from Kubernetes v1.12 #293
Conversation
Hmm, it looks like Kubernetes changed
|
I like that option better. |
I think in the short term, we should do the first, and then file an issue to follow up and remove this lookup table thing and replace it with some kind of aliasing. My reasoning is basically that we are absolutely, 100% going to encounter this again. This is the sort of thing Kubernetes does all the time. |
I love that we can so easily pick up all the new features (and docs!) - really nice to see this!
To be clear, is your short term proposal to map the "new" names back to the "old" names for compatibility? I notice that in places like |
@lukehoban that's correct, yes. Temporarily mapping it back to the old name would solve this problem everywhere, except one place, which is our CRD class -- that we have to fix manually. I do think we need to solve the problem though -- this situation is guaranteed to come up again. |
Mental note for me to do early in M20 that we need to manually regenerate the Python casing table again (#258). |
Absolutely. Can you open an issue to track this so we make sure to tackle it? |
393c124
to
370e323
Compare
370e323
to
319bb0a
Compare
Ok, I think this is nearly ready to merge.
|
319bb0a
to
9ecc914
Compare
9ecc914
to
abc66e5
Compare
No description provided.