-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic with Job resource diffing against an unreachable cluster #3024
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3024 +/- ##
=======================================
Coverage 36.47% 36.48%
=======================================
Files 70 70
Lines 9160 9163 +3
=======================================
+ Hits 3341 3343 +2
- Misses 5489 5491 +2
+ Partials 330 329 -1 ☔ View full report in Codecov by Sentry. |
4941116
to
26bef16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes me wonder if we should also check if the cluster is unreachable inside readLiveObject
, seems like an easy mistake to make otherwise.
26bef16
to
80a3ed4
Compare
Sounds good! Added an assert as a precheck for |
97fecb8
to
2616e49
Compare
This PR has been shipped in release v4.13.1. |
Proposed changes
This PR ensures that we do not make a k8s API request during the provider's diff if there is an unreachable cluster. This currently occurs when the Pulumi program contains a Job resource with the
replaceUnready
annotation set to true. A panic would occur if we attempt to make the API call since our clients are nil.Testing done:
Related issues (optional)
Fixes: #3022