Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kubernetes schema and client libraries to v1.31 #3144

Merged
merged 13 commits into from
Aug 13, 2024
Merged

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Jul 31, 2024

Followed the runbook here.

Quick notes/observations:

  • I don't think updating cloud-ready-checks is strictly necessary.
  • Would it be helpful to have Dependabot tracking pre-release tags for k8s dependencies? That would give us a PR that takes care of most of the go.mod updates.
  • k8s.io/kube-openapi seems like our only dependency that's not tagged and needs to take latest.
  • Deprecations were added here.

Fixes #3063.

@blampe blampe marked this pull request as draft July 31, 2024 20:45
Copy link

github-actions bot commented Jul 31, 2024

Does the PR have any schema changes?

Found 15 breaking changes:

Resources

  • 🟢 "kubernetes:admissionregistration.k8s.io/v1:ValidatingAdmissionPolicyBindingList": required inputs: "items" input has changed to Required
  • 🟢 "kubernetes:admissionregistration.k8s.io/v1:ValidatingAdmissionPolicyList": required inputs: "items" input has changed to Required
  • 🟢 "kubernetes:admissionregistration.k8s.io/v1alpha1:ValidatingAdmissionPolicyBindingList": required inputs: "items" input has changed to Required
  • 🟢 "kubernetes:admissionregistration.k8s.io/v1alpha1:ValidatingAdmissionPolicyList": required inputs: "items" input has changed to Required
  • 🟢 "kubernetes:admissionregistration.k8s.io/v1beta1:ValidatingAdmissionPolicyBindingList": required inputs: "items" input has changed to Required
  • 🟢 "kubernetes:admissionregistration.k8s.io/v1beta1:ValidatingAdmissionPolicyList": required inputs: "items" input has changed to Required

Types

  • 🟢 "kubernetes:admissionregistration.k8s.io/v1:ValidatingAdmissionPolicyBindingList": required: "items" property has changed to Required
  • 🟢 "kubernetes:admissionregistration.k8s.io/v1:ValidatingAdmissionPolicyList": required: "items" property has changed to Required
  • 🟢 "kubernetes:admissionregistration.k8s.io/v1alpha1:ValidatingAdmissionPolicyBindingList": required: "items" property has changed to Required
  • 🟢 "kubernetes:admissionregistration.k8s.io/v1alpha1:ValidatingAdmissionPolicyList": required: "items" property has changed to Required
  • 🟢 "kubernetes:admissionregistration.k8s.io/v1beta1:ValidatingAdmissionPolicyBindingList": required: "items" property has changed to Required
  • 🟢 "kubernetes:admissionregistration.k8s.io/v1beta1:ValidatingAdmissionPolicyList": required: "items" property has changed to Required
  • 🟢 "kubernetes:core/v1:HostAlias": required: "ip" property has changed to Required
  • 🟢 "kubernetes:core/v1:HostIP": required: "ip" property has changed to Required
  • 🟢 "kubernetes:core/v1:PodIP": required: "ip" property has changed to Required

New resources:

  • coordination.k8s.io/v1alpha1.LeaseCandidate
  • coordination.k8s.io/v1alpha1.LeaseCandidateList
  • coordination.k8s.io/v1alpha1.LeaseCandidatePatch
  • networking.k8s.io/v1beta1.IPAddress
  • networking.k8s.io/v1beta1.IPAddressList
  • networking.k8s.io/v1beta1.IPAddressPatch
  • networking.k8s.io/v1beta1.ServiceCIDR
  • networking.k8s.io/v1beta1.ServiceCIDRList
  • networking.k8s.io/v1beta1.ServiceCIDRPatch
  • resource.k8s.io/v1alpha3.DeviceClass
  • resource.k8s.io/v1alpha3.DeviceClassList
  • resource.k8s.io/v1alpha3.DeviceClassPatch
  • resource.k8s.io/v1alpha3.PodSchedulingContext
  • resource.k8s.io/v1alpha3.PodSchedulingContextList
  • resource.k8s.io/v1alpha3.PodSchedulingContextPatch
  • resource.k8s.io/v1alpha3.ResourceClaim
  • resource.k8s.io/v1alpha3.ResourceClaimList
  • resource.k8s.io/v1alpha3.ResourceClaimPatch
  • resource.k8s.io/v1alpha3.ResourceClaimTemplate
  • resource.k8s.io/v1alpha3.ResourceClaimTemplateList
  • resource.k8s.io/v1alpha3.ResourceClaimTemplatePatch
  • resource.k8s.io/v1alpha3.ResourceSlice
  • resource.k8s.io/v1alpha3.ResourceSlicePatch
  • storage.k8s.io/v1beta1.VolumeAttributesClass
  • storage.k8s.io/v1beta1.VolumeAttributesClassList
  • storage.k8s.io/v1beta1.VolumeAttributesClassPatch

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.50%. Comparing base (7c31739) to head (770bae5).

Files Patch % Lines
provider/pkg/kinds/deprecated.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3144      +/-   ##
==========================================
- Coverage   36.51%   36.50%   -0.01%     
==========================================
  Files          70       70              
  Lines        9230     9232       +2     
==========================================
  Hits         3370     3370              
- Misses       5528     5530       +2     
  Partials      332      332              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rquitales
Copy link
Member

@blampe We'll need to do something similar to fb32acb to handle the removed APIs, and potentially update deprecated.go.

@blampe blampe marked this pull request as ready for review August 13, 2024 17:14
@blampe blampe requested a review from EronWright August 13, 2024 17:15
Copy link
Contributor

@EronWright EronWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blampe blampe merged commit 5d981f9 into master Aug 13, 2024
19 checks passed
@blampe blampe deleted the blampe/v1.31.0 branch August 13, 2024 19:20
blampe added a commit that referenced this pull request Aug 13, 2024
- Updated Kubernetes schemas and libraries to v1.31.0. (#3144)

- `Services` with selectors targeting 0 `Pods` will no longer hang indefinitely. (#605)
- `Services` without selectors will no longer hang indefinitely. (#799)
blampe added a commit that referenced this pull request Aug 13, 2024
### Changed 

- Updated Kubernetes schemas and libraries to v1.31.0.
(#3144)

### Fixed

- `Services` with selectors targeting 0 `Pods` will no longer hang
indefinitely. (#605)
- `Services` without selectors will no longer hang indefinitely.
(#799)
lumiere-bot bot referenced this pull request in coolguy1771/home-ops Aug 14, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@pulumi/kubernetes](https://pulumi.com)
([source](https://github.com/pulumi/pulumi-kubernetes)) | dependencies
| minor | [`4.16.0` ->
`4.17.0`](https://renovatebot.com/diffs/npm/@pulumi%2fkubernetes/4.16.0/4.17.0)
|

---

### Release Notes

<details>
<summary>pulumi/pulumi-kubernetes (@&#8203;pulumi/kubernetes)</summary>

###
[`v4.17.0`](https://github.com/pulumi/pulumi-kubernetes/blob/HEAD/CHANGELOG.md#4170-August-13-2024)

[Compare
Source](https://github.com/pulumi/pulumi-kubernetes/compare/v4.16.0...v4.17.0)

##### Changed

- Updated Kubernetes schemas and libraries to v1.31.0.
([https://github.com/pulumi/pulumi-kubernetes/pull/3144](https://github.com/pulumi/pulumi-kubernetes/pull/3144))

##### Fixed

- `Services` with selectors targeting 0 `Pods` will no longer hang
indefinitely.

[https://github.com/pulumi/pulumi-kubernetes/issues/605](https://github.com/pulumi/pulumi-kubernetes/issues/605)/605)
-   `Services` without selectors will no longer hang indefinitely.

[https://github.com/pulumi/pulumi-kubernetes/issues/799](https://github.com/pulumi/pulumi-kubernetes/issues/799)/799)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNy4wIiwidXBkYXRlZEluVmVyIjoiMzguMjcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9taW5vciJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
@mjeffryes mjeffryes added this to the 0.108 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support k8s 1.31 on release
4 participants