Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set pulumi-kubernetes python dependency #3210

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

rquitales
Copy link
Member

Proposed changes

When setting p-k as a python dependency for schemagen, we also need to include the == token to generate a valid pyproject.toml file.

Related issues (optional)

Related: pulumi/crd2pulumi#148

@rquitales rquitales self-assigned this Sep 16, 2024
@rquitales rquitales added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Sep 16, 2024
Copy link
Contributor

@blampe blampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh!!

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 40.84%. Comparing base (7155e2e) to head (6e3c283).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/gen/schema.go 0.00% 5 Missing ⚠️
provider/pkg/gen/typegen.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3210      +/-   ##
==========================================
+ Coverage   38.60%   40.84%   +2.23%     
==========================================
  Files          84       84              
  Lines        9866     9876      +10     
==========================================
+ Hits         3809     4034     +225     
+ Misses       5695     5459     -236     
- Partials      362      383      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from rquitales/fix-patch-for-list to master September 16, 2024 23:02
@rquitales rquitales enabled auto-merge (squash) September 16, 2024 23:09
@rquitales rquitales merged commit 74673fd into master Sep 16, 2024
19 checks passed
@rquitales rquitales deleted the rquitales/fix-python branch September 16, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants