Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node-fetch rather than got to support node 6 #390

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Use node-fetch rather than got to support node 6 #390

merged 1 commit into from
Feb 1, 2019

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Feb 1, 2019 •
edited
Loading

Fixes #372

@lblackstone lblackstone requested a review from lukehoban February 1, 2019 19:23
lukehoban
lukehoban approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I assume we've manually validated against Node 6?

I wonder if there's an easy way to run nightlies against an older version of Node to get some coverage there? /cc @ellismg

@lblackstone
Copy link
Member Author

@lukehoban Yes, I tested it locally with node v6.10.2.

@lblackstone lblackstone merged commit bb8a2d6 into master Feb 1, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/node6-fix branch February 1, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehoban lukehoban lukehoban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lblackstone @lukehoban