-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up nodejs SDK into multiple files #480
Conversation
I'm still working on fixing the exports, but the API types seem to be generating correctly at this point. |
fb83cff
to
0249eb1
Compare
0249eb1
to
83b3cf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see a diff of the kind generating code in provider.ts.mustache
and kind.ts.mustache
to make doubly sure we're ready to merge this, but other than that, I trust that our tests would fail catastrophically if we messed this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, why is input.ts and output.ts changing so much? Those should be diff-free right?
Ah, appears that the change I made in |
Here's the diff: 1,5c1,7
< {{#Groups}}
< export namespace {{Group}} {
< {{#Versions}}
< export namespace {{Version}} {
< {{#Kinds}}
---
> // *** WARNING: this file was generated by the Pulumi Kubernetes codegen tool. ***
> // *** Do not edit by hand unless you're certain you know what you are doing! ***
>
> import * as pulumi from "@pulumi/pulumi";
> import * as inputApi from "../../types/input";
> import * as outputApi from "../../types/output";
>
13d14
<
34,39c35,40
< * Create a {{Group}}.{{Version}}.{{Kind}} resource with the given unique name, arguments, and options.
< *
< * @param name The _unique_ name of the resource.
< * @param args The arguments to use to populate this resource's properties.
< * @param opts A bag of options that control this resource's behavior.
< */
---
> * Create a {{Group}}.{{Version}}.{{Kind}} resource with the given unique name, arguments, and options.
> *
> * @param name The _unique_ name of the resource.
> * @param args The arguments to use to populate this resource's properties.
> * @param opts A bag of options that control this resource's behavior.
> */
50,56d50
< {{/Kinds}}
< }
<
< {{/Versions}}
< }
<
< {{/Groups}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright I think this makes sense, it's a little weird that the resource TS files are capitalized, but I don't see an easy way to fix that.
Fixes #479