-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put all resources in specified provider namespace #538
Conversation
96e8bc4
to
f6083b0
Compare
3a319f8
to
0f66cc2
Compare
Error is:
Not sure yet if that's legit, or if https://github.com/pulumi/pulumi-kubernetes/pull/538/files#diff-6155820fac2dd2fda7353505b1f69319R307 is invalid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM. It'd be great to get a description somewhere of the logic being done here w.r.t how we're:
- handling CR / CRDs
- the need for
overrideNamespace
- following the code it makes sense, but its hard to reason about which namespace we're using / not using
@metral I think I addressed all your feedback. Added a note to the code clarifying the override behavior. CRs are a special case because it isn't always possible to tell if they are Namespaced/Global scoped during preview. As noted in the code, this could result in a namespace being set erroneously on a Cluster-scoped CR for previews, but this would be corrected during the Create step, when the required information is available. This correction will be reflected in further updates/diffs as well, so even if the erroneous namespace on the resource changes, it will not require a replacement. |
@hausdorff Have you had a chance to look this over? The main change from the previously-merged #506 is the improved logic related to unregistered CRs. See the explanation in my comment to Mike for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is an updated version of #506 that should correctly handle CRs.
Fixes #415