Allow customizing ResourceOptions in transformations #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 29, 2019 15:02
Adds the ability for transformations to see the current ResourceOptions and modify it if desired on an per-resource basis. Fixes #574.
lukehoban
commented
May 30, 2019
| # Allow users to change API objects before any validation. | ||
| if transformations is not None: | ||
| for t in transformations: | ||
| obj = t(obj) |
There was a problem hiding this comment.
BTW - note that this code previous did obj = t(obj) which is not the same semantics as JavaScript, and is possibly quite surprising. It's also not compatible with the change we want to make here.
I went ahead and changed it, though this is a breaking change. Curious if there's feedback on whether to take the breaking change to align these, or to adjust the PR somehow else to avoid it?
There was a problem hiding this comment.
Yeah, I'd go with the breaking change. It was unintentional behavior introduced when I ported from the Node SDK, and isn't widely used yet. We had at least one user mention that it was surprising, so I'd been intending to fix it anyway.
lblackstone
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for transformations to see the current ResourceOptions and modify it if desired on an per-resource basis.
Fixes #574.