Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Python codegen fixes #771

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Various Python codegen fixes #771

merged 2 commits into from
Aug 29, 2019

Conversation

hausdorff
Copy link
Contributor

@hausdorff hausdorff commented Aug 28, 2019 •
edited
Loading

Fixes #768.
Fixes #763.

@hausdorff hausdorff requested a review from lblackstone August 28, 2019 23:14
lblackstone
lblackstone requested changes Aug 28, 2019
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after docs fix. Up to you on the import syntax

pkg/gen/python-templates/helm/v2/helm.py Outdated Show resolved Hide resolved
pkg/gen/python-templates/yaml.py.mustache Show resolved Hide resolved
lukehoban
lukehoban reviewed Aug 29, 2019
View reviewed changes
pkg/gen/python-templates/helm/v2/helm.py Outdated Show resolved Hide resolved
pkg/gen/python-templates/helm/v2/helm.py Outdated Show resolved Hide resolved
@hausdorff hausdorff requested a review from lblackstone August 29, 2019 17:52
@hausdorff hausdorff merged commit 0d18b59 into master Aug 29, 2019
@pulumi-bot pulumi-bot deleted the hausdorff/py-fixes branch August 29, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

@lukehoban lukehoban lukehoban left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hausdorff @lukehoban @lblackstone