Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn for invalid usage of Helm repo parameter #805

Merged
merged 2 commits into from
Sep 16, 2019

Conversation

lblackstone
Copy link
Member

Proposed changes

The Chart resource contains two similarly named variables
that are used for different purposes. Print a more informative
error message for a common usage mistake.

Related issues (optional)

Fixes #623

The Chart resource contains two similarly named variables
that are used for different purposes. Print a more informative
error message for a common usage mistake.
@lblackstone lblackstone requested a review from metral September 16, 2019 20:23
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are there docs we can also add this distinction into?

@lblackstone
Copy link
Member Author

@metral Updated the docs to make this a bit clearer.

@metral
Copy link
Contributor

metral commented Sep 16, 2019

@metral Updated the docs to make this a bit clearer.

LGTM

@lblackstone lblackstone merged commit c4d0bb0 into master Sep 16, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/helm-usage-error branch September 16, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Error: invalid chart URL format
2 participants