Stop using initialApiVersion annotation #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 1.2.0 release, we added the pulumi.com/initialApiVersion annotation, which was used internally by the provider. This caused the side effect of requiring updates to all existing resources. This change instead stores that information in the state file, and no longer creates an annotation. To avoid further disruption, the annotation is not removed if it already exists, but will be ignored by the provider.
pgavlin
reviewed
Oct 9, 2019
pgavlin
approved these changes
Oct 9, 2019
hausdorff
reviewed
Oct 9, 2019
lblackstone
force-pushed
the
lblackstone/initial-api-version
branch
from
f646cfc to
a38489e
Compare
|
@hausdorff You're right; I was not handling pre-1.2 resources correctly. Fixed in the latest commit. |
hausdorff
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the 1.2.0 release, we added the pulumi.com/initialApiVersion annotation,
which was used internally by the provider. This caused the side effect of
requiring updates to all existing resources.
This change instead stores that information in the state file, and no longer
creates an annotation. To avoid further disruption, the annotation is not
removed if it already exists, but will be ignored by the provider.
Related issues (optional)
Fixes #834