Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HELM_HOME as default if set #855

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Conversation

lblackstone
Copy link
Member

Proposed changes

Previously, the Chart resource ignored the HELM_HOME
environment variable. This value is now used as a default
if set. Note that the fetch home option still takes
precedence over HELM_HOME.

Related issues (optional)

Fixes #854

@lblackstone lblackstone requested a review from hausdorff October 21, 2019 20:20
@lblackstone lblackstone requested review from pgavlin and removed request for hausdorff December 3, 2019 05:38
@lblackstone lblackstone force-pushed the lblackstone/helm-home branch from 83b8312 to 6f75c19 Compare December 3, 2019 05:46
pkg/gen/nodejs-templates/helm/v2/helm.ts Outdated Show resolved Hide resolved
pkg/gen/nodejs-templates/helm/v2/helm.ts Outdated Show resolved Hide resolved
Previously, the Chart resource ignored the HELM_HOME
environment variable. This value is now used as a default
if set. Note that the fetch `home` option still takes
precedence over HELM_HOME.
@lblackstone lblackstone force-pushed the lblackstone/helm-home branch from 6f75c19 to 4c924a4 Compare December 3, 2019 18:39
@lblackstone lblackstone force-pushed the lblackstone/helm-home branch from 4c924a4 to 11d2654 Compare December 3, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HELM_HOME environment variable is ignored
2 participants