Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maxBuffer for helm template exec #864

Merged
merged 3 commits into from
Nov 5, 2019
Merged

Increase maxBuffer for helm template exec #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35df5c9
Increase maxBuffer for helm template exec
Sep 26, 2019
9479daa
Update CHANLOGELOG.md
Sep 26, 2019
7bcb9e8
Make change in template
lblackstone Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
- v1.15.x
- v1.14.x

### Improvements

- Increase maxBuffer for helm template exec. (https://github.com/pulumi/pulumi-kubernetes/pull/864).

## 1.2.3 (October 17, 2019)

### Supported Kubernetes versions
Expand Down
5 changes: 4 additions & 1 deletion pkg/gen/nodejs-templates/helm/v2/helm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,10 @@ export class Chart extends yaml.CollectionComponentResource {
? `--namespace ${shell.quote([cfg.namespace])}`
: "";
const yamlStream = execSync(
`helm template ${chart} --name ${release} --values ${defaultValues} --values ${values} ${namespaceArg}`
`helm template ${chart} --name ${release} --values ${defaultValues} --values ${values} ${namespaceArg}`,
{
maxBuffer: 512 * 1024 * 1024 // 512 MB
},
).toString();
return this.parseTemplate(yamlStream, cfg.transformations, cfg.resourcePrefix, configDeps);
} catch (e) {
Expand Down
5 changes: 4 additions & 1 deletion sdk/nodejs/helm/v2/helm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,10 @@ export class Chart extends yaml.CollectionComponentResource {
? `--namespace ${shell.quote([cfg.namespace])}`
: "";
const yamlStream = execSync(
`helm template ${chart} --name ${release} --values ${defaultValues} --values ${values} ${namespaceArg}`
`helm template ${chart} --name ${release} --values ${defaultValues} --values ${values} ${namespaceArg}`,
{
maxBuffer: 512 * 1024 * 1024 // 512 MB
},
).toString();
return this.parseTemplate(yamlStream, cfg.transformations, cfg.resourcePrefix, configDeps);
} catch (e) {
Expand Down