-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .NET code generation #885
Conversation
Fixed with 514f017. |
Also add back CRD example
@lblackstone @CyrusNajmabadi @mikhailshilkov @hausdorff @pgavlin This now ready for review. Tests are passing for the Guestbook example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this coming! I left several small comments.
Also stop disabling scrict null checks.
Skimmed over this and nothing looks out of place or concerning. If you have any particular areas you'd like me to look more deeply at, just call them out. But, otherwise, if this works then this works :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - It looks correct as far as I can tell, but the syntax on the example is pretty hideous. Guessing there's no way around that while maintaining strong typing.
Also pass version information. Also split tests in two.
Adds core code-generation support for .NET to the Kubernetes provider.
Part of #863.