Add helm template apiVersions flag #894
Conversation
|
@hausdorff what do you think of this approach to solve the |
|
One quick note - is it possible to add a test? There are some tests in |
|
@lukehoban thanks for pointing out the example tests. Working on adding one now |
There was a problem hiding this comment.
@RichardWLaub Thanks for the PR, and sorry for the delayed response! Just a few more suggestions, and then I'll run this through CI and get it merged.
| /** | ||
| * The optional kubernetes api versions used for Capabilities.APIVersions. | ||
| */ | ||
| apiVersions?: pulumi.Input<string[]>; |
There was a problem hiding this comment.
| apiVersions?: pulumi.Input<string[]>; | |
| apiVersions?: pulumi.Input<pulumi.Input<string>[]>; |
tests/examples/helm-api-versions/helm-api-versions/templates/test-pod.yaml
Show resolved
Hide resolved
| new k8s.helm.v2.Chart("api-versions", { | ||
| apiVersions: ["foo", "bar"], | ||
| path: "helm-api-versions", | ||
| transformations: [ |
There was a problem hiding this comment.
With the suggested update to the Pod manifest, you can update this to
new k8s.helm.v2.Chart("api-versions", {
apiVersions: ["foo", "bar"],
path: "helm-api-versions",
namespace: namespace.metadata.name,
});| import * as k8s from "@pulumi/kubernetes"; | ||
|
|
||
| const namespace = new k8s.core.v1.Namespace("test"); | ||
| const namespaceName = namespace.metadata.name; |
There was a problem hiding this comment.
Not needed with suggested update.
| const namespaceName = namespace.metadata.name; |
RichardWLaub
force-pushed
the
rl/helm-template-api-versions
branch
from
512fdf8 to
ba8ce52
Compare
| ? `--api-versions={${cfg.apiVersions | ||
| .map(apiVersion => shell.quote([apiVersion])) | ||
| .join(',')}}` | ||
| : `--api-versions=${cfg.apiVersions |
There was a problem hiding this comment.
It looks like the length would only be 1 here, so how about
`---api-versions=${shell.quote(cfg.apiVersions[0])}`There was a problem hiding this comment.
Thanks for the suggestion. shell.quote takes a string[] so I just passed in apiVersions.
|
Merged these changes in in #951 Thanks for the contribution! |
Proposed changes
Allows me to pass the
--api-versionsflag tohelm templateso I can deploy helm chart resources with the following conditional:Note that example was taken from the prometheus-cloudwatch-exporter helm chart.
Related issues
Fixes #196