Update aliases and deprecation warnings #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add aliases for `NetworkPolicy`, `PodSecurityPolicy`, and `PriorityClass`. * Update "removed in" warning for `rbac/v1alpha1` and `rbac/v1beta1`
metral
approved these changes
Dec 17, 2019
|
Once question mostly for curiosity - are there primary sources for any of these mappings either in docs or in upstream source code? Would be great to link to them from our mappings in code so that we can more easily determine if/when there has been drift in the future. |
|
Unfortunately there’s no single source of truth here. Release notes generally discuss deprecations, but this hasn’t been consistent between releases. I’ll go ahead and add links for ones I can find. |
lblackstone
force-pushed
the
lblackstone/more-aliases
branch
from
dfd5b77 to
be63213
Compare
|
@metral I missed a few more aliases/deprecations, and added some reference comments |
metral
approved these changes
Dec 17, 2019
Open
1 task
This was referenced Dec 17, 2019
1 task
This was referenced Dec 17, 2019
This was referenced Jan 7, 2020
This was referenced Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
NetworkPolicy,PodSecurityPolicy, andPriorityClass.rbac/v1alpha1andrbac/v1beta1Related issues (optional)
Fixes #919