Implement ResourceProviderServer#Cancel
#94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hausdorff
force-pushed
the
hausdorff/sigint
branch
from
93cb07b to
016e0b5
Compare
hausdorff
force-pushed
the
hausdorff/sigint
branch
4 times, most recently
from
4ffddf1 to
2bfa155
Compare
This commit will implement `Cancel`, the new function exposed on the gRPC resource provider server interface introduced in pulumi/pulumi #1633. The semantics of `Cancel` are to issue a non-blocking, advisory cancellation signal to all resource operations in progress. In practice, since the Kubernetes Go client does not take a cancellation context to cancel resource operations that are currently in flight, in the case of the Kubernetes resource provider, we will typically cancel as we are waiting for the resource operation (e.g., initialization) to complete. In other words, the HTTP request we use to signal resource creation to the Kubernetes API server will never be cancelled in flight; if the resource is complex enough to require initialization, we'll cancel at the nearest opportunity. Fixes #89.
hausdorff
force-pushed
the
hausdorff/sigint
branch
from
2bfa155 to
0c14773
Compare
swgillespie
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will implement
Cancel, the new function exposed on thegRPC resource provider server interface introduced in
pulumi/pulumi#1633.
The semantics of
Cancelare to issue a non-blocking, advisorycancellation signal to all resource operations in progress.
In practice, since the Kubernetes Go client does not take a cancellation
context to cancel resource operations that are currently in flight, in
the case of the Kubernetes resource provider, we will typically cancel
as we are waiting for the resource operation (e.g., initialization) to
complete. In other words, the HTTP request we use to signal resource
creation to the Kubernetes API server will never be cancelled in flight;
if the resource is complex enough to require initialization, we'll
cancel at the nearest opportunity.