Fix deprecated tag in JSDoc comments #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
added
the
impact/no-changelog-required
lblackstone
reviewed
Jan 8, 2020
There was a problem hiding this comment.
Change LGTM, but let's hold off on this until I've released #941
|
@justinvp This will need a rebase now that I've fixed the CSINode thing |
The description in the doc comment should come before the `@deprecated` tag, otherwise the description will be included as part of the deprecation message.
justinvp
force-pushed
the
justin/deprecated
branch
from
7d37748 to
a76f93d
Compare
|
@lblackstone Rebased |
lblackstone
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description in the doc comment should come before the
@deprecatedtag, otherwise the description will be included as part of the deprecation message.Part of pulumi/docs#2229
Related: pulumi/pulumi-eks#301