Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for k8s 1.19 #996

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Add support for k8s 1.19 #996

merged 3 commits into from
Aug 26, 2020

Conversation

lblackstone
Copy link
Member

Proposed changes

Related issues (optional)

Fixes #995

@lblackstone lblackstone force-pushed the lblackstone/k8s-1.19 branch from e04202d to 95e6cb3 Compare March 26, 2020 19:39
@lblackstone lblackstone force-pushed the lblackstone/k8s-1.19 branch from 95e6cb3 to 02d2e0e Compare April 21, 2020 19:58
@lblackstone lblackstone force-pushed the lblackstone/k8s-1.19 branch from b3298af to dbe5237 Compare May 19, 2020 16:01
@lblackstone lblackstone force-pushed the lblackstone/k8s-1.19 branch from dbe5237 to 2be04f4 Compare June 4, 2020 15:07
@lblackstone lblackstone force-pushed the lblackstone/k8s-1.19 branch from 2be04f4 to d4c2acc Compare June 12, 2020 18:21
@lblackstone lblackstone force-pushed the lblackstone/k8s-1.19 branch from d4c2acc to 7533bd2 Compare July 2, 2020 20:42
@lblackstone lblackstone force-pushed the lblackstone/k8s-1.19 branch from e476a37 to a056bb6 Compare July 21, 2020 18:57
@lblackstone lblackstone force-pushed the lblackstone/k8s-1.19 branch 2 times, most recently from 2cafa9b to ea2915c Compare August 4, 2020 23:42
@lblackstone lblackstone force-pushed the lblackstone/k8s-1.19 branch 4 times, most recently from 0f4bb5b to d907876 Compare August 25, 2020 06:13
@lblackstone lblackstone force-pushed the lblackstone/k8s-1.19 branch from e559244 to 7aea0d0 Compare August 25, 2020 15:19
@lblackstone
Copy link
Member Author

This is the final RC before release, so there should be no further API changes. I'll push the final PR tomorrow once the v1.19 tag is cut.

Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

Given that the bulk of the changes here are codegen'd I'll defer to CI and regression tests to keep us honest across SDKs.

provider/pkg/kinds/deprecated.go Show resolved Hide resolved
@lblackstone lblackstone marked this pull request as ready for review August 26, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support k8s 1.19 on release
2 participants