-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for k8s 1.19 #996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
from
February 28, 2020 21:01
2301151
to
e04202d
Compare
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
from
March 26, 2020 19:39
e04202d
to
95e6cb3
Compare
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
from
April 21, 2020 19:58
95e6cb3
to
02d2e0e
Compare
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
from
May 19, 2020 16:01
b3298af
to
dbe5237
Compare
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
from
June 4, 2020 15:07
dbe5237
to
2be04f4
Compare
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
from
June 12, 2020 18:21
2be04f4
to
d4c2acc
Compare
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
from
July 2, 2020 20:42
d4c2acc
to
7533bd2
Compare
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
from
July 21, 2020 18:57
e476a37
to
a056bb6
Compare
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
2 times, most recently
from
August 4, 2020 23:42
2cafa9b
to
ea2915c
Compare
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
4 times, most recently
from
August 25, 2020 06:13
0f4bb5b
to
d907876
Compare
lblackstone
force-pushed
the
lblackstone/k8s-1.19
branch
from
August 25, 2020 15:19
e559244
to
7aea0d0
Compare
This is the final RC before release, so there should be no further API changes. I'll push the final PR tomorrow once the v1.19 tag is cut. |
metral
reviewed
Aug 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Given that the bulk of the changes here are codegen'd I'll defer to CI and regression tests to keep us honest across SDKs.
metral
approved these changes
Aug 26, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues (optional)
Fixes #995