-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation docs #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
guineveresaenger
added a commit
to pulumi/pulumi-terraform-bridge
that referenced
this pull request
Nov 19, 2024
This pull request does a couple of things: - Implement a render function for each subset of Table - Expand the `tableRenderer` struct to hold state - initialize a separate Renderer for the table renderer, since the logic for cell rendering calls back into the outer renderer and trying to use the same renderer lost track of content. - add tests to reflect a table in the middle of a document to ensure text after the table continues to get rendered - ad an overall doc test that contains a table. PR using this change: pulumi/pulumi-sdwan#114 Fixes #2466
guineveresaenger
force-pushed
the
guin/installation-docs
branch
from
December 2, 2024 17:41
aad367d
to
492d3b0
Compare
guineveresaenger
added
the
needs-release/patch
When a PR with this label merges, it initiates a release of vX.Y.Z+1
label
Dec 2, 2024
mjeffryes
approved these changes
Dec 2, 2024
This PR has been shipped in release v0.2.2. |
github-actions
bot
removed
the
needs-release/patch
When a PR with this label merges, it initiates a release of vX.Y.Z+1
label
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/pulumi/home/issues/3598.