Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation docs #114

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Add installation docs #114

merged 6 commits into from
Dec 2, 2024

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Nov 18, 2024

Part of https://github.com/pulumi/home/issues/3598.

  • Add automation
  • First stab at docs
  • Removing bogus whitespace results in no bogus extra frontmatter
  • Table renders correctly
  • Fix table rendering

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

guineveresaenger added a commit to pulumi/pulumi-terraform-bridge that referenced this pull request Nov 19, 2024
This pull request does a couple of things:

- Implement a render function for each subset of Table
- Expand the `tableRenderer` struct to hold state
- initialize a separate Renderer for the table renderer, since the logic
for cell rendering calls back into the outer renderer and trying to use
the same renderer lost track of content.
- add tests to reflect a table in the middle of a document to ensure
text after the table continues to get rendered
- ad an overall doc test that contains a table.

PR using this change: pulumi/pulumi-sdwan#114
Fixes #2466
@guineveresaenger guineveresaenger added the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Dec 2, 2024
@guineveresaenger guineveresaenger marked this pull request as ready for review December 2, 2024 17:43
@guineveresaenger guineveresaenger requested a review from a team December 2, 2024 17:43
@guineveresaenger guineveresaenger merged commit 3271f90 into main Dec 2, 2024
23 checks passed
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v0.2.2.

@github-actions github-actions bot removed the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants