Fix adding empty values to maps #1498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1498 +/- ##
==========================================
- Coverage 61.93% 57.88% -4.05%
==========================================
Files 184 286 +102
Lines 32836 39618 +6782
==========================================
+ Hits 20336 22933 +2597
- Misses 11362 15348 +3986
- Partials 1138 1337 +199
... and 102 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
t0yv0
commented
Nov 1, 2023
| @@ -189,7 +189,17 @@ func makePropertyDiff(ctx context.Context, name, path string, v resource.Propert | |||
| name += ".%" | |||
| } | |||
| } | |||
| if d := tfDiff.Attribute(name); d != nil && d.Old != d.New { | |||
|
|
|||
| if d := tfDiff.Attribute(name); d != nil && | |||
There was a problem hiding this comment.
Instead of going with this, I could consider also detecting changes to map counts. The diff has an entry for tags.% that's changing, indicating the number of tags is changing, but is being ignored by makeDetailedDiff. Speaking of which this needs test cases also for changing a non-empty entry to empty and vise versa, and for removing an empty entry, the whole CRUD.
|
Closing in favor of #1502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD