Fix flaky dynamic/TestConfigure test #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73a8116 introduced a test with a race condition between parallel tests. This PR separates the stateful and stateless tests into TestConfigure and TestCheckConfig respectively. It removes the race condition.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2130 +/- ##
==========================================
+ Coverage 60.64% 61.40% +0.76%
==========================================
Files 350 349 -1
Lines 45793 38090 -7703
==========================================
- Hits 27770 23390 -4380
+ Misses 16491 13174 -3317
+ Partials 1532 1526 -6 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Jun 26, 2024
|
This PR has been shipped in release v3.86.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
73a8116 introduced a test with a race condition between parallel tests. This PR separates the stateful and stateless tests into TestConfigure and TestCheckConfig respectively. It removes the race condition.
Fixes #2129