tweaks for clarity #2143
Merged
tweaks for clarity #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
==========================================
- Coverage 60.63% 60.63% -0.01%
==========================================
Files 350 350
Lines 45898 45898
==========================================
- Hits 27832 27831 -1
- Misses 16527 16528 +1
Partials 1539 1539 ☔ View full report in Codecov by Sentry. |
iwahbe
approved these changes
Jun 27, 2024
|
This PR has been shipped in release v3.86.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just a suggestion - it wasn't very clear to me what "parameterization" means in the context of dynamic providers. It felt like it was referring to a very specific concept, but it didn't really go into what that was. It feels like we could wait to talk about it until we do have that doc and concept laid out.
Feel free to ignore - these would've been my comments on #2137.