-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated install instructions to top of installation-configuration.md
.
#2207
Conversation
…age name. Refactor functionality into new file. Add unit tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2207 +/- ##
==========================================
- Coverage 61.30% 60.60% -0.71%
==========================================
Files 353 355 +2
Lines 38512 46324 +7812
==========================================
+ Hits 23611 28076 +4465
- Misses 13354 16694 +3340
- Partials 1547 1554 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
//TODO: See https://github.com/pulumi/pulumi-terraform-bridge/issues/2078 | ||
// - translate code blocks with code choosers | ||
// - apply default edit rules | ||
// - reformat TF names | ||
// - Translation for certain headers such as "Arguments Reference" or "Configuration block" | ||
// - Ability to omit irrelevant sections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this accurately describes the set of features we need to start shipping this on tier 2 providers.
"title: %[1]s Installation & Configuration\n"+ | ||
"meta_desc: Provides an overview on how to configure the Pulumi %[1]s.\n"+ | ||
"layout: package\n"+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are excellent places to use backtick based strings.
This PR has been shipped in release v3.88.0. |
This PR adds an "Installation" section to the configuration docs, generating content dynamically from the package info.
Fixes #2206.