Respect versions for dynamic providers #2220
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2220 +/- ##
==========================================
+ Coverage 60.61% 60.65% +0.04%
==========================================
Files 356 356
Lines 46368 46433 +65
==========================================
+ Hits 28104 28164 +60
- Misses 16706 16709 +3
- Partials 1558 1560 +2 ☔ View full report in Codecov by Sentry. |
| @@ -35,6 +36,7 @@ func providerInfo(ctx context.Context, p run.Provider, value parameterize.Value) | |||
| Name: p.Name(), | |||
| Version: p.Version(), | |||
| Description: "A Pulumi provider dynamically bridged from " + p.Name() + ".", | |||
| Publisher: "Pulumi", | |||
There was a problem hiding this comment.
I feel like this should be the author/publisher of the bridged provider.
Our docs describe publisher as: "The name of the person or organization that authored and published the package."
Given that there's not really any authoring here it should use the original author imo
There was a problem hiding this comment.
We are the "publisher" of the bridged provider (if it is published), but not the author. It's a grey area IMO.
| @@ -43,6 +45,19 @@ func providerInfo(ctx context.Context, p run.Provider, value parameterize.Value) | |||
| Path: "", Data: tfbridge.ProviderMetadata(nil), | |||
| }, | |||
|
|
|||
| Python: &tfbridge.PythonInfo{ | |||
| PyProject: struct{ Enabled bool }{true}, | |||
| RespectSchemaVersion: true, | |||
There was a problem hiding this comment.
You don't actually need to set RespectSchemaVersion. Having something in Parameterization tells codegen to require a version and embed it anyway.
iwahbe
force-pushed
the
iwahbe/pre-dynamic-providers
branch
from
bfb8fa4 to
73cbc7c
Compare
|
This PR has been shipped in release v3.88.0. |
This is necessary to generate easily consumable SDKs.